incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Re: Review Request: Made DRF per user and log(N)
Date Wed, 08 Aug 2012 00:29:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 8, 2012, 12:29 a.m.)

Review request for mesos and Benjamin Hindman.


Updated to the most recent review.

This patch now assumes that you've applied:


Rewrote the DRF algorithm in DominantShareAllocator to calculate shares on a per user, rather
than per framework, basis and to store those shares in sorted order so that allocations have
log(n) time complexity instead of n^2.

Significant restructuring of the allocator code to make writing new allocators easier:

- The Allocator class is renamed AllocatorProcess.
- A new Allocator class is introduced which knows only about "elements" (either user names
or frameworkIds) and how many resources they have been allocated, and then has an interface
for retrieving the elements in the order they should be allocated to.
- SimpleAllocatorProcess which can be used with different Allocators to carry out different
allocation policies, including the possibility of having different policies for the per-user
and per-framework allocations.

Why is this restructuring a good thing?
Now that we're doing allocations based on users, rather than frameworks, we have to do two
levels of allocation - determine which user to give resources to, then determine which of
their frameworks to actually make the offer to. Rather than hard-coding the allocation policies
in, the new Allocator class allows us to reuse the same code to do both levels of allocation,
and it allows us to easily swap different policies in or mix and match. You can even imagine
some day having an allocator that allows each user to pick the per-framework allocation policy
they prefer.

Merely giving SimpleAllocatorProcess different Allocators is not sufficient to implement all
allocation policies - only those where all resources are considered equal and there is no
revocation. But, you can always create new AllocatorProcess subclasses (there will soon be
a code review where I implement a static allocator this way) and these new AllocatorProcess
classes can still reuse Allocators as appropriate.

It also makes testing the allocator logic a lot easier since we can instantiate Allocators,
give them arbitrary elements, and check that they return the right thing, instead of worrying
about instantiating slaves/frameworks and using mock objects.

This addresses bugs MESOS-225 and MESOS-226.

Diffs (updated)

  src/ cc3480c 
  src/local/local.hpp 8ae5b9e 
  src/local/local.cpp 46537d7 
  src/master/allocator.hpp c6273b5 
  src/master/allocator.cpp PRE-CREATION 
  src/master/dominant_share_allocator.hpp ba5dc29 
  src/master/dominant_share_allocator.cpp 00a47f7 
  src/master/drf_sorter.hpp PRE-CREATION 
  src/master/drf_sorter.cpp PRE-CREATION 
  src/master/flags.hpp 1227ccc 
  src/master/main.cpp 172772f 
  src/master/master.hpp 30e3f75 
  src/master/master.cpp b174f7f 
  src/master/simple_allocator_process.hpp PRE-CREATION 
  src/master/simple_allocator_process.cpp PRE-CREATION 
  src/master/sorter.hpp PRE-CREATION 
  src/master/sorter.cpp PRE-CREATION 
  src/tests/allocator_tests.cpp b3db13d 
  src/tests/allocator_zookeeper_tests.cpp PRE-CREATION 
  src/tests/fault_tolerance_tests.cpp f892282 
  src/tests/master_detector_tests.cpp 758c8b9 
  src/tests/master_tests.cpp b586984 
  src/tests/resource_offers_tests.cpp c004772 
  src/tests/slave_tests.cpp e9b25ba 
  src/tests/utils.hpp a768360 



make check on Lion


Thomas Marshall

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message