Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF0AE98F8 for ; Mon, 30 Jul 2012 16:54:12 +0000 (UTC) Received: (qmail 98423 invoked by uid 500); 30 Jul 2012 16:54:12 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 98392 invoked by uid 500); 30 Jul 2012 16:54:12 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 98379 invoked by uid 99); 30 Jul 2012 16:54:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2012 16:54:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D02D11C18BA; Mon, 30 Jul 2012 16:54:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3041750341504565843==" MIME-Version: 1.0 Subject: Re: Review Request: FD_CLOEXEC the pipes in slave From: "Vinod Kone" To: "Benjamin Hindman" , "Brian Wickman" , "John Sirois" Cc: "Jie Yu" , "mesos" , "Vinod Kone" Date: Mon, 30 Jul 2012 16:54:11 -0000 Message-ID: <20120730165411.22301.770@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/6146/ X-Sender: "Vinod Kone" References: <20120728004629.4030.18805@reviews.apache.org> In-Reply-To: <20120728004629.4030.18805@reviews.apache.org> Reply-To: "Vinod Kone" --===============3041750341504565843== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6146/ ----------------------------------------------------------- (Updated July 30, 2012, 4:54 p.m.) Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman. Changes ------- ben's comments Description ------- See summary This addresses bug MESOS-244. https://issues.apache.org/jira/browse/MESOS-244 Diffs (updated) ----- src/exec/exec.cpp d60c28d = src/slave/process_based_isolation_module.cpp b54f91c = src/webui/webui.cpp 9453002 = third_party/libprocess/include/stout/os.hpp 1186d24 = Diff: https://reviews.apache.org/r/6146/diff/ Testing ------- Need more specific tests. But 'make check' succeeds. Thanks, Vinod Kone --===============3041750341504565843==--