Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 655D8D83D for ; Fri, 20 Jul 2012 15:49:27 +0000 (UTC) Received: (qmail 71602 invoked by uid 500); 20 Jul 2012 15:49:27 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 71567 invoked by uid 500); 20 Jul 2012 15:49:27 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 71555 invoked by uid 99); 20 Jul 2012 15:49:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2012 15:49:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 94F861C037B; Fri, 20 Jul 2012 15:49:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0700430333194938844==" MIME-Version: 1.0 Subject: Re: Review Request: Added a mechanism for dynamically toggling the verbose logging level. From: "John Sirois" To: "Vinod Kone" , "John Sirois" Cc: "mesos" , "Benjamin Hindman" Date: Fri, 20 Jul 2012 15:49:26 -0000 Message-ID: <20120720154926.14837.72246@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Sirois" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/6056/ X-Sender: "John Sirois" References: <20120720062639.14837.49163@reviews.apache.org> In-Reply-To: <20120720062639.14837.49163@reviews.apache.org> Reply-To: "John Sirois" --===============0700430333194938844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6056/#review9312 ----------------------------------------------------------- Ship it! src/logging/logging.cpp So is __sync_synchronize a gflags symbol or do you happen to know it al= so uses a read barrier? - John Sirois On July 20, 2012, 6:26 a.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6056/ > ----------------------------------------------------------- > = > (Updated July 20, 2012, 6:26 a.m.) > = > = > Review request for mesos, John Sirois and Vinod Kone. > = > = > Description > ------- > = > See summary. > = > = > Diffs > ----- > = > src/logging/logging.cpp 074765f = > third_party/libprocess/include/process/http.hpp 2ef8a3d = > third_party/libprocess/include/stout/time.hpp 4819b9e = > third_party/libprocess/src/process.cpp b560b7c = > = > Diff: https://reviews.apache.org/r/6056/diff/ > = > = > Testing > ------- > = > make check > = > And manually via: > = > $ curl 'localhost:5050/logging/toggle?level=3D3&duration=3D10secs' > = > = > Thanks, > = > Benjamin Hindman > = > --===============0700430333194938844==--