Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24243DF12 for ; Tue, 10 Jul 2012 23:40:00 +0000 (UTC) Received: (qmail 5166 invoked by uid 500); 10 Jul 2012 23:40:00 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 5137 invoked by uid 500); 10 Jul 2012 23:40:00 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 5124 invoked by uid 99); 10 Jul 2012 23:39:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2012 23:39:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 618801C1747; Tue, 10 Jul 2012 23:39:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8034809464508532823==" MIME-Version: 1.0 Subject: Re: Review Request: Made DRF per user and log(N) From: "Thomas Marshall" To: "Benjamin Hindman" Cc: "Thomas Marshall" , "mesos" Date: Tue, 10 Jul 2012 23:39:59 -0000 Message-ID: <20120710233959.729.52219@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thomas Marshall" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/5599/ X-Sender: "Thomas Marshall" References: <20120709225503.766.64481@reviews.apache.org> In-Reply-To: <20120709225503.766.64481@reviews.apache.org> Reply-To: "Thomas Marshall" --===============8034809464508532823== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5599/ ----------------------------------------------------------- (Updated July 10, 2012, 11:39 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- Updated patch to trunk. Description ------- Rewrote the DRF algorithm in DominantShareAllocator to calculate shares on = a per user, rather than per framework, basis and to store those shares in s= orted order so that allocations have log(n) time complexity instead of n^2. This patch relies on 3 pending code reviews: https://reviews.apache.org/r/5448/ https://reviews.apache.org/r/5451/ https://reviews.apache.org/r/5532/ This addresses bugs MESOS-225 and MESOS-226. https://issues.apache.org/jira/browse/MESOS-225 https://issues.apache.org/jira/browse/MESOS-226 Diffs (updated) ----- src/Makefile.am eb1944f = src/local/local.hpp 55f9eaf = src/local/local.cpp 8186595 = src/master/allocator.hpp 12f31db = src/master/allocator.cpp PRE-CREATION = src/master/allocator_process.hpp PRE-CREATION = src/master/dominant_share_allocator.hpp 650e441 = src/master/dominant_share_allocator.cpp a1f2fdc = src/master/main.cpp c321618 = src/master/master.hpp e523aa1 = src/master/master.cpp f6e5459 = src/master/simple_allocator_process.hpp PRE-CREATION = src/master/simple_allocator_process.cpp PRE-CREATION = src/tests/allocator_tests.cpp 610826b = src/tests/fault_tolerance_tests.cpp dd578aa = src/tests/master_detector_tests.cpp afd8a74 = src/tests/master_tests.cpp 69a07e9 = src/tests/resource_offers_tests.cpp d06cae2 = src/tests/slave_tests.cpp a8d6b74 = src/tests/utils.hpp ca51af5 = Diff: https://reviews.apache.org/r/5599/diff/ Testing ------- make check on Lion Thanks, Thomas Marshall --===============8034809464508532823==--