incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhongbo Tian" <>
Subject Re: Review Request: Patch to fix leak in libprocess
Date Wed, 11 Jul 2012 03:34:51 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 11, 2012, 3:34 a.m.)

Review request for mesos, Benjamin Hindman and Vinod Kone.


It seems that libprocess has memory-leaking problem.
When state is not in pending, refs will be decreased an extra time to become -1, and then
memory leaked.
So the solution I proposed is that guard the discard function with a pair of increament/decrement
of refs,
and it will be safe to verify if refs is zero out of the guard scope.


  third_party/libprocess/include/process/future.hpp 1aa8ffd 



Test is done in our deployment enviroment, and seems all right.


Zhongbo Tian

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message