Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1373E9D87 for ; Mon, 25 Jun 2012 17:40:57 +0000 (UTC) Received: (qmail 23838 invoked by uid 500); 25 Jun 2012 17:40:56 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 23798 invoked by uid 500); 25 Jun 2012 17:40:56 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 23788 invoked by uid 99); 25 Jun 2012 17:40:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2012 17:40:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6BB3A1C0A72; Mon, 25 Jun 2012 17:40:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0740645640330085044==" MIME-Version: 1.0 Subject: Re: Review Request: Renamed SimpleAllocator to DominantShareAllocator From: "Benjamin Hindman" To: "Benjamin Hindman" Cc: "Thomas Marshall" , "mesos" Date: Mon, 25 Jun 2012 17:40:55 -0000 Message-ID: <20120625174055.10352.36805@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/5448/ X-Sender: "Benjamin Hindman" References: <20120622233636.22488.22444@reviews.apache.org> In-Reply-To: <20120622233636.22488.22444@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============0740645640330085044== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5448/#review8547 ----------------------------------------------------------- Ship it! src/master/allocator_factory.cpp We should probably ultimately eliminate this file. - Benjamin Hindman On June 22, 2012, 11:36 p.m., Thomas Marshall wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5448/ > ----------------------------------------------------------- > = > (Updated June 22, 2012, 11:36 p.m.) > = > = > Review request for mesos and Benjamin Hindman. > = > = > Description > ------- > = > Renamed SimpleAllocator to DominantShareAllocator. > = > = > Diffs > ----- > = > src/Makefile.am 8760f59 = > src/local/local.cpp d35639f = > src/master/allocator_factory.cpp e4f4969 = > src/master/dominant_share_allocator.hpp PRE-CREATION = > src/master/dominant_share_allocator.cpp PRE-CREATION = > src/master/main.cpp bcbe35a = > src/master/master.hpp 886f79c = > src/master/simple_allocator.hpp 034b5d0 = > src/master/simple_allocator.cpp 1c54feb = > src/tests/exception_tests.cpp de7fcf3 = > src/tests/fault_tolerance_tests.cpp b2529ca = > src/tests/master_detector_tests.cpp 4cefbfa = > src/tests/master_tests.cpp fcaf7dc = > src/tests/resource_offers_tests.cpp c1f1760 = > src/tests/slave_tests.cpp 84e8e7d = > = > Diff: https://reviews.apache.org/r/5448/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Thomas Marshall > = > --===============0740645640330085044==--