Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 323D3C257 for ; Thu, 24 May 2012 22:52:29 +0000 (UTC) Received: (qmail 53466 invoked by uid 500); 24 May 2012 22:52:29 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 53371 invoked by uid 500); 24 May 2012 22:52:28 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 53350 invoked by uid 99); 24 May 2012 22:52:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 May 2012 22:52:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6496A1C409F; Thu, 24 May 2012 22:52:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5373675902413384375==" MIME-Version: 1.0 Subject: Re: Review Request: Created a file paging/tailing abstraction ("pailer") as a jquery plugin so we can easily view logs from browsers. From: "John Sirois" To: "Brian Wickman" , "John Sirois" Date: Thu, 24 May 2012 22:52:26 -0000 Message-ID: <20120524225226.3611.5842@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/5201/ Cc: "mesos" , "Benjamin Hindman" In-Reply-To: <20120522235632.14920.32323@reviews.apache.org> References: <20120522235632.14920.32323@reviews.apache.org> --===============5373675902413384375== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5201/#review8092 ----------------------------------------------------------- Ship it! src/webui/master/static/jquery.pailer.js Is no space between close-paren and { the style for anonymous functions= ? its not used elsewhere below for non-anonymous functions. src/webui/master/static/jquery.pailer.js It seems like this_.url should be checked as well - I assume your nice = 404 traps later will not apply for a null url, this_.element is used below = so will fail fast anyway so perhaps not needed src/webui/master/static/jquery.pailer.js consider extracting trimToLine - this block of 4 statements is used aga= in in tail src/webui/master/static/jquery.pailer.js Don't know a good word, but this does truncate on the head which is not= really typical truncate. - John On 2012-05-22 23:56:32, Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5201/ > ----------------------------------------------------------- > = > (Updated 2012-05-22 23:56:32) > = > = > Review request for mesos, John Sirois and Brian Wickman. > = > = > Summary > ------- > = > See summary. > = > = > Diffs > ----- > = > src/webui/master/static/jquery.pailer.js PRE-CREATION = > = > Diff: https://reviews.apache.org/r/5201/diff > = > = > Testing > ------- > = > = > Thanks, > = > Benjamin > = > --===============5373675902413384375==--