Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37E4FC205 for ; Fri, 11 May 2012 00:59:56 +0000 (UTC) Received: (qmail 72256 invoked by uid 500); 11 May 2012 00:59:56 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 72160 invoked by uid 500); 11 May 2012 00:59:55 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 72147 invoked by uid 99); 11 May 2012 00:59:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2012 00:59:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 548051C3F6D; Fri, 11 May 2012 00:59:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5588522444807263638==" MIME-Version: 1.0 Subject: Re: Review Request: Extended utils From: "Vinod Kone" To: "John Sirois" Date: Fri, 11 May 2012 00:59:54 -0000 Message-ID: <20120511005954.1539.29122@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4899/ Cc: "Vinod Kone" , "mesos" , "Benjamin Hindman" In-Reply-To: <20120504002813.13266.63174@reviews.apache.org> References: <20120504002813.13266.63174@reviews.apache.org> --===============5588522444807263638== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4899/ ----------------------------------------------------------- (Updated 2012-05-11 00:59:54.273443) Review request for mesos and John Sirois. Changes ------- ben's comments Summary ------- We can now read/write strings to a file. Some common utils for working with protobuf objects. Diffs (updated) ----- src/Makefile.am cd503a8 = src/common/protobuf_utils.hpp PRE-CREATION = src/common/utils.hpp 1d81e21 = src/slave/slave.cpp 09a8396 = src/tests/protobuf_io_tests.cpp 22f37ac = src/tests/utils_tests.cpp 49ec107 = Diff: https://reviews.apache.org/r/4899/diff Testing ------- make check Thanks, Vinod --===============5588522444807263638==--