Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 695C1C82C for ; Fri, 4 May 2012 17:33:58 +0000 (UTC) Received: (qmail 17800 invoked by uid 500); 4 May 2012 17:33:58 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 17738 invoked by uid 500); 4 May 2012 17:33:57 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 17724 invoked by uid 99); 4 May 2012 17:33:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2012 17:33:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A9F11C37FC; Fri, 4 May 2012 17:33:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1560173477283201968==" MIME-Version: 1.0 Subject: Re: Review Request: Added "state" abstraction, including implementations using leveldb and ZooKeeper. From: "Vinod Kone" To: "Vinod Kone" , "John Sirois" Date: Fri, 04 May 2012 17:33:56 -0000 Message-ID: <20120504173356.19285.17782@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4981/ Cc: "Benjamin Hindman" , "mesos" In-Reply-To: <20120504003751.13266.5517@reviews.apache.org> References: <20120504003751.13266.5517@reviews.apache.org> --===============1560173477283201968== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4981/#review7569 ----------------------------------------------------------- src/state/state.hpp why pointer instead of ref? src/state/leveldb.cpp reorder src/state/leveldb.cpp weren't u gonna use Result instead? src/state/leveldb.cpp swap feels like a bad name here. update/insert perhaps? - Vinod On 2012-05-04 00:37:51, Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4981/ > ----------------------------------------------------------- > = > (Updated 2012-05-04 00:37:51) > = > = > Review request for mesos, John Sirois and Vinod Kone. > = > = > Summary > ------- > = > This is the beginning of a the components for saving "state" information,= including what slaves are connected, what frameworks are running, etc. I'l= l be adding a ZooKeeperState implementation soon, and the master and it's c= omponents will use it to save state in a distributed way. > = > = > Diffs > ----- > = > src/Makefile.am cd503a8 = > src/messages/state.hpp PRE-CREATION = > src/messages/state.proto PRE-CREATION = > src/state/leveldb.cpp PRE-CREATION = > src/state/state.hpp PRE-CREATION = > src/state/zookeeper.cpp PRE-CREATION = > src/tests/base_zookeeper_test.hpp f35acc0 = > src/tests/state_tests.cpp PRE-CREATION = > src/zookeeper/group.cpp da2e147 = > = > Diff: https://reviews.apache.org/r/4981/diff > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Benjamin > = > --===============1560173477283201968==--