incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-188) declineOffer() should be added to Python-C++ bindings and used in test_framework.py
Date Wed, 02 May 2012 02:26:48 GMT

    [ https://issues.apache.org/jira/browse/MESOS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266300#comment-13266300
] 

jiraposter@reviews.apache.org commented on MESOS-188:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4960/#review7459
-----------------------------------------------------------

Ship it!


LGTM. (You should add Ben to this review to encourage him to commit it.)

- Charles


On 2012-05-02 02:14:55, Harvey Feng wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4960/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-02 02:14:55)
bq.  
bq.  
bq.  Review request for Charles Reiss.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  - This should allow python frameworks to call to call driver.declineOffer().
bq.  - Added declineOffer() in test_framework.py example
bq.  
bq.  
bq.  This addresses bug MESOS-188.
bq.      https://issues.apache.org/jira/browse/MESOS-188
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/examples/python/test_framework.py dd9cf98 
bq.    src/python/native/mesos_scheduler_driver_impl.cpp b8fd16d 
bq.  
bq.  Diff: https://reviews.apache.org/r/4960/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Harvey
bq.  
bq.


                
> declineOffer() should be added to Python-C++ bindings and used in test_framework.py
> -----------------------------------------------------------------------------------
>
>                 Key: MESOS-188
>                 URL: https://issues.apache.org/jira/browse/MESOS-188
>             Project: Mesos
>          Issue Type: Bug
>          Components: python-api
>            Reporter: Harvey Feng 
>            Assignee: Harvey Feng 
>
> Came across this while trying to call driver.declineOffer()
> Traceback (most recent call last):
>   File "./nmpiexec.py", line 76, in resourceOffers
>     driver.declineOffer(offer.id)
> AttributeError: '_mesos.MesosSchedulerDriverImpl' object has no attribute 'declineOffer'
> It should involve a quick fix in src/python/native/mesos_scheduler_diver_imp.cpp
> declineOffer() should also be used in src/examples/python/test_framework.py, which currently
holds offers that it should decline if tasksLaunched >= TOTAL_TASKS

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message