incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Fix for slave segfault on framework exit
Date Tue, 08 May 2012 17:05:18 GMT


> On 2012-05-07 21:50:01, John Sirois wrote:
> > src/slave/slave.cpp, line 1487
> > <https://reviews.apache.org/r/5057/diff/2/?file=107599#file107599line1487>
> >
> >     Is there a test that could be tweaked to ensure this is happening?  Presumably
it wasn't before via executorExited?

added a test.


> On 2012-05-07 21:50:01, John Sirois wrote:
> > src/slave/slave.cpp, line 1483
> > <https://reviews.apache.org/r/5057/diff/2/?file=107599#file107599line1483>
> >
> >     Does this new api call still transition live tasks to LOST/FAILED?

This is a bit nuanced. When a framework is shutdown, the slave sends a shutdown to the executor.
One of the 2 things might happen.

1) EXECUTOR_SHUTDOWN_TIMEOUT_SECONDS elapses before the isolation module informs about the
lost executor.  A TASK_LOST  will be sent by 
   the slave to the master. But the master drops it to the floor because the framework is
dead.

2) Isolation module informs about lost executor before EXECUTOR_SHUTDOWN_TIMEOUT_SECONDS.
Slave doesn't send a TASK_LOST.

In either case, the master never sends the TASK_LOST to the dead framework, which is the right
thing to do.


This might be different when we have slave recovery implemented, but the logic there for handling
status updates is very different. In other words, this fix will 
probably go away when we merge slave recovery stuff.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5057/#review7657
-----------------------------------------------------------


On 2012-05-07 21:11:34, Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5057/
> -----------------------------------------------------------
> 
> (Updated 2012-05-07 21:11:34)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Summary
> -------
> 
> Fix for: https://issues.apache.org/jira/browse/MESOS-190
> 
> Also prevents slave from infinitely re-trying status updates to a dead framework.
> 
> 
> This addresses bug MESOS-190.
>     https://issues.apache.org/jira/browse/MESOS-190
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 09a8396 
> 
> Diff: https://reviews.apache.org/r/5057/diff
> 
> 
> Testing
> -------
> 
> Checked with long lived framework.
> 
> $ ./bin/mesos-master.sh
> $ ./bin/mesos-slave.sh --master=localhost:5050
> $./src/long-lived-framework localhost:5050
> 
> 
> Thanks,
> 
> Vinod
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message