Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 75F3A9D40 for ; Thu, 26 Apr 2012 06:33:49 +0000 (UTC) Received: (qmail 15745 invoked by uid 500); 26 Apr 2012 06:33:49 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 15712 invoked by uid 500); 26 Apr 2012 06:33:49 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 15703 invoked by uid 99); 26 Apr 2012 06:33:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2012 06:33:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2012 06:33:46 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 23333410F55 for ; Thu, 26 Apr 2012 06:33:25 +0000 (UTC) Date: Thu, 26 Apr 2012 06:33:25 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: mesos-dev@incubator.apache.org Message-ID: <1595325349.4104.1335422005203.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1009749120.6401.1328243393640.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (MESOS-145) mesos executor holds on to fd spawned by slave after slave death, preventing slave from restarting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262409#comment-13262409 ] jiraposter@reviews.apache.org commented on MESOS-145: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4891/#review7254 ----------------------------------------------------------- Ship it! Gracias Amigo! - Benjamin On 2012-04-26 06:24:51, Vinod Kone wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4891/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-26 06:24:51) bq. bq. bq. Review request for mesos, Benjamin Hindman and John Sirois. bq. bq. bq. Summary bq. ------- bq. bq. This should fix MESOS-145 bq. bq. bq. This addresses bug mesos-145. bq. https://issues.apache.org/jira/browse/mesos-145 bq. bq. bq. Diffs bq. ----- bq. bq. third_party/libprocess/src/net.hpp 498e920 bq. third_party/libprocess/src/process.cpp d77b156 bq. bq. Diff: https://reviews.apache.org/r/4891/diff bq. bq. bq. Testing bq. ------- bq. bq. make check (on mac) bq. bq. bq. Thanks, bq. bq. Vinod bq. bq. > mesos executor holds on to fd spawned by slave after slave death, preventing slave from restarting > -------------------------------------------------------------------------------------------------- > > Key: MESOS-145 > URL: https://issues.apache.org/jira/browse/MESOS-145 > Project: Mesos > Issue Type: Bug > Reporter: brian wickman > Assignee: Benjamin Hindman > > The slaves spin on this error trying to start up as long as my (admittedly badly behaving) executor holds onto the handle the MesosDriver uses for communication with the slave: > F0203 04:26:18.204121 580 process.cpp:1177] Failed to initialize, bind: Address already in use [98] > *** Check failure stack trace: *** > @ 0x7f258750db4d google::LogMessage::Fail() > @ 0x7f25875137b7 google::LogMessage::SendToLog() > @ 0x7f258750f3fc google::LogMessage::Flush() > @ 0x7f258750f629 google::LogMessage::~LogMessage() > @ 0x7f258750f72d google::ErrnoLogMessage::~ErrnoLogMessage() > @ 0x7f258752517d process::initialize() > @ 0x4067fa main > @ 0x7f2585dae994 __libc_start_main > @ 0x405c99 (unknown) > Ben identified the root cause as needing to fcntl(F_SETFD) on the fd prior to fork. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira