incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <>
Subject Re: Review Request: Logging and configuration cleanup.
Date Thu, 26 Apr 2012 20:25:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-04-26 20:25:04.529822)

Review request for mesos and John Sirois.


Review comments.


Scratched some itches and cleaned up some aspects of logging and configuration:
    (1) Removed initializing glog from within libprocess (that should
        never have been done, if a user wants that they should just set
        GLOG_* environment variables before initializing libprocess).
    (2) Make 'localquiet' actually be quiet again.
    (3) Added a 'once' abstraction to libprocess (needed to only
        initialize logging once).
    (4) Made mesos-tests actually use logging and configuration.
    (5) Removed unused Configuration methods (and cleaned up existing APIs
        as well as how they were getting called/used).

Diffs (updated)

  src/common/logging.hpp f0cee46 
  src/common/logging.cpp bd9c36f 
  src/common/webui_utils.cpp fc0cc6c 
  src/configurator/configuration.hpp 7addfa4 
  src/exec/exec.cpp e8db407 
  src/local/local.cpp affe432 
  src/local/main.cpp ffb2585 
  src/log/log.cpp 84e03be 
  src/log/main.cpp 3cf680c 
  src/master/main.cpp f2bad09 
  src/master/webui.cpp 9f26417 
  src/mesos/main.cpp a121a42 
  src/sched/sched.cpp dcadb10 
  src/slave/lxc_isolation_module.cpp 66a2a89 
  src/slave/main.cpp 85cba25 
  src/slave/process_based_isolation_module.cpp 2b37d42 
  src/slave/slave.hpp 0dc7140 
  src/slave/slave.cpp b233b68 
  src/slave/webui.cpp 1782f6c 
  src/tests/main.cpp c546b8d 
  third_party/libprocess/include/process/nothing.hpp PRE-CREATION 
  third_party/libprocess/include/process/once.hpp PRE-CREATION 
  third_party/libprocess/include/process/process.hpp 8e957cb 
  third_party/libprocess/src/process.cpp 5c1123c 



make check



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message