Return-Path: 
 <mesos-dev-return-1606-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CD070930B
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Tue, 20 Mar 2012 21:18:46 +0000 (UTC)
Received: (qmail 23868 invoked by uid 500); 20 Mar 2012 21:18:46 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 23836 invoked by uid 500); 20 Mar 2012 21:18:46 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 23825 invoked by uid 99); 20 Mar 2012 21:18:46 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Mar 2012 21:18:46 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id F30771C38B6;
	Tue, 20 Mar 2012 21:18:45 +0000 (UTC)
Content-Type: multipart/alternative;
	boundary="===============8882744668799606522=="
MIME-Version: 1.0
Subject: Re: Review Request: Additional logic needed for CommandInfo (see
 description).
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Vinod Kone" <vinodkone@gmail.com>, "John Sirois" <john.sirois@gmail.com>
Date: Tue, 20 Mar 2012 21:18:45 -0000
Message-ID: <20120320211845.32682.92987@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
X-ReviewRequest-URL: https://reviews.apache.org/r/4408/
Cc: "mesos" <mesos-dev@incubator.apache.org>,
	"Benjamin Hindman" <benh@berkeley.edu>
In-Reply-To: <20120320154501.32682.83573@reviews.apache.org>
References: <20120320154501.32682.83573@reviews.apache.org>

--===============8882744668799606522==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable



> On 2012-03-20 15:45:01, John Sirois wrote:
> >

Thank you, submitting.


> On 2012-03-20 15:45:01, John Sirois wrote:
> > src/common/try.hpp, line 41
> > <https://reviews.apache.org/r/4408/diff/1/?file=3D93749#file93749line41>
> >
> >     why not private / force Try::error("") ?

Because I figured the code looked better when you do something like:

Try<T> t;
if (conditional) {
  t =3D Try<T>::some(expression);
} else {
  t =3D Try<T>::some(expression);
}

if (t.isSome()) {
...

than:

Try<T> t =3D Try<T>::error("Uninitialized Try");
...


> On 2012-03-20 15:45:01, John Sirois wrote:
> > src/master/master.cpp, line 1440
> > <https://reviews.apache.org/r/4408/diff/1/?file=3D93751#file93751line14=
40>
> >
> >     Are there sanity checks anywhere that task.has_command() !=3D task.=
has_executor()

Great question! Yes, when you try and launch a task we make sure that only =
one of CommandInfo or ExecutorInfo is set (and fail the task if not).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4408/#review6122
-----------------------------------------------------------


On 2012-03-20 00:55:15, Benjamin Hindman wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4408/
> -----------------------------------------------------------
> =

> (Updated 2012-03-20 00:55:15)
> =

> =

> Review request for mesos, John Sirois and Vinod Kone.
> =

> =

> Summary
> -------
> =

> Made sure the slave sends status updates for tasks launched via a Command=
Info and updated Task to make 'executor_id' optional for the cases when a t=
ask was launched with a CommandInfo (w/ corresponding changes in the master=
 and slave)."[commandinfo_exit 4858fe1] Made sure the slave sends status up=
dates for tasks launched via a CommandInfo and updated Task to make 'execut=
or_id' optional for the cases when a task was launched with a CommandInfo (=
w/ corresponding changes in the master and slave).
> =

> =

> Diffs
> -----
> =

>   src/common/try.hpp ed5611b =

>   src/launcher/executor.cpp aac1053 =

>   src/master/master.cpp 0222bb2 =

>   src/messages/messages.proto 11a2c41 =

>   src/slave/reaper.cpp 93e47e7 =

>   src/slave/slave.hpp de304cb =

>   src/slave/slave.cpp ddd1874 =

> =

> Diff: https://reviews.apache.org/r/4408/diff
> =

> =

> Testing
> -------
> =

> make check
> =

> =

> Thanks,
> =

> Benjamin
> =

>


--===============8882744668799606522==--