Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECDDB9DDC for ; Thu, 15 Mar 2012 18:18:10 +0000 (UTC) Received: (qmail 60076 invoked by uid 500); 15 Mar 2012 18:18:10 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 60043 invoked by uid 500); 15 Mar 2012 18:18:10 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 60031 invoked by uid 99); 15 Mar 2012 18:18:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2012 18:18:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 992791C37C2; Thu, 15 Mar 2012 18:18:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5198881697867333720==" MIME-Version: 1.0 Subject: Re: Review Request: Added versioning information into headers, updated Java's MesosNativeLibrary to expect a specific native library version, and removed the JAR file from getting installed as well as the Python egg. From: "Benjamin Hindman" To: "Charles Reiss" Date: Thu, 15 Mar 2012 18:18:09 -0000 Message-ID: <20120315181809.4803.64504@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4298/ Cc: "mesos" , "Benjamin Hindman" In-Reply-To: <20120313054424.7140.99155@reviews.apache.org> References: <20120313054424.7140.99155@reviews.apache.org> --===============5198881697867333720== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-03-13 05:44:24, Charles Reiss wrote: > > LGTM. Thanks, submitting! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4298/#review5870 ----------------------------------------------------------- On 2012-03-12 22:11:19, Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4298/ > ----------------------------------------------------------- > = > (Updated 2012-03-12 22:11:19) > = > = > Review request for mesos and Charles Reiss. > = > = > Summary > ------- > = > See summary. > = > = > Diffs > ----- > = > configure.ac de26a05 = > include/mesos/mesos.hpp 41ddfb6 = > include/mesos/mesos.hpp.in PRE-CREATION = > src/Makefile.am 10dbafd = > src/common/build.hpp 868cf97 = > src/examples/java/TestFramework.java ff8eb4b = > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in PRE-CREA= TION = > src/java/jni/convert.cpp 6db4f25 = > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e = > src/java/src/org/apache/mesos/MesosNativeLibrary.java 8a9615f = > = > Diff: https://reviews.apache.org/r/4298/diff > = > = > Testing > ------- > = > make && make check && make hadoop && make install DESTDIR=3D/tmp/local > = > = > Thanks, > = > Benjamin > = > --===============5198881697867333720==--