Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
	boundary="===============1426321184434824343=="
MIME-Version: 1.0
Subject: Re: Review Request: Added versioning information into headers,
 updated Java's MesosNativeLibrary to expect a specific native library
 version,
 and removed the JAR file from getting installed as well as the Python egg.
From: "Charles Reiss" <woggling@gmail.com>
To: "Charles Reiss" <woggling@gmail.com>
Date: Tue, 13 Mar 2012 05:44:33 -0000
Message-ID: <20120313054433.7141.54826@reviews.apache.org>
Cc: "Benjamin Hindman" <benh@berkeley.edu>,
	"mesos" <mesos-dev@incubator.apache.org>
In-Reply-To: <20120312220107.7140.12287@reviews.apache.org>
References: <20120312220107.7140.12287@reviews.apache.org>

--===============1426321184434824343==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On 2012-03-12 22:01:07, Charles Reiss wrote:
> > configure.ac, line 21
> > <https://reviews.apache.org/r/4298/diff/1/?file=3D91267#file91267line21>
> >
> >     Do we want to bless anything with this version number until we thin=
k we have an actual release candidate?
> =

> Benjamin Hindman wrote:
>     I'd like to  make 0.9.0 the release candidate. We were debating betwe=
en 0.9.0 and 1.0.0 but the latter implies a stable API, and I'd like to giv=
e us a little bit of runway after the first release to shake out any cobweb=
s that others might run across.

I don't have any objections to this, but I assume others will have opinions=
 on it.


> On 2012-03-12 22:01:07, Charles Reiss wrote:
> > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in, line 46
> > <https://reviews.apache.org/r/4298/diff/1/?file=3D91273#file91273line46>
> >
> >     I assume you're deliberately not doing mesos-@PACKAGE_VERSION@ here?
> =

> Benjamin Hindman wrote:
>     Yes. My thinking was that if we had a versioning scheme we're comfort=
able with we could imagine loading e.g., 2.6.8 even if MesosNativeLibrary w=
as built with 2.6.4 (as well as possibly SNAPSHOT versions).

I assume you imagine that the C++ code is going to do that sort of compatib=
ility check.


- Charles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4298/#review5856
-----------------------------------------------------------


On 2012-03-12 22:11:19, Benjamin Hindman wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4298/
> -----------------------------------------------------------
> =

> (Updated 2012-03-12 22:11:19)
> =

> =

> Review request for mesos and Charles Reiss.
> =

> =

> Summary
> -------
> =

> See summary.
> =

> =

> Diffs
> -----
> =

>   configure.ac de26a05 =

>   include/mesos/mesos.hpp 41ddfb6 =

>   include/mesos/mesos.hpp.in PRE-CREATION =

>   src/Makefile.am 10dbafd =

>   src/common/build.hpp 868cf97 =

>   src/examples/java/TestFramework.java ff8eb4b =

>   src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in PRE-CREA=
TION =

>   src/java/jni/convert.cpp 6db4f25 =

>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e =

>   src/java/src/org/apache/mesos/MesosNativeLibrary.java 8a9615f =

> =

> Diff: https://reviews.apache.org/r/4298/diff
> =

> =

> Testing
> -------
> =

> make && make check && make hadoop && make install DESTDIR=3D/tmp/local
> =

> =

> Thanks,
> =

> Benjamin
> =

>


--===============1426321184434824343==--