Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72F0C9D1E for ; Tue, 6 Mar 2012 16:09:44 +0000 (UTC) Received: (qmail 94487 invoked by uid 500); 6 Mar 2012 16:09:44 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 94452 invoked by uid 500); 6 Mar 2012 16:09:44 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 94437 invoked by uid 99); 6 Mar 2012 16:09:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 16:09:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB40B1C029F; Tue, 6 Mar 2012 16:09:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3162180781678020777==" MIME-Version: 1.0 Subject: Re: Review Request: Adding support to launcher.cpp to retrieve files (executors) via HTTP From: "Florian Leibert" To: "Benjamin Hindman" Date: Tue, 06 Mar 2012 16:09:43 -0000 Message-ID: <20120306160943.24747.9012@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4119/ Cc: "Charles Reiss" , "mesos" , "Florian Leibert" In-Reply-To: <20120302140915.7288.14166@reviews.apache.org> References: <20120302140915.7288.14166@reviews.apache.org> --===============3162180781678020777== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 212 > > > > > > Check if this fails? using the os::open wrapper now - in case an error happens the launcher woul= d die. > On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 222 > > > > > > Do you have some reason to believe that if this fails (e.g. connect= ion closed before response is complete), then CURLINFO_RESPONSE_CODE won't = be 200? checking now the actual curl error code, i.e. not just the http status code. > On 2012-03-02 14:09:15, Charles Reiss wrote: > > src/launcher/launcher.cpp, line 236 > > > > > > Check return value? (e.g. out of disk space/quota). done - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4119/#review5539 ----------------------------------------------------------- On 2012-03-06 15:58:46, Florian Leibert wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4119/ > ----------------------------------------------------------- > = > (Updated 2012-03-06 15:58:46) > = > = > Review request for mesos and Benjamin Hindman. > = > = > Summary > ------- > = > Launcher can now retrieve an executor specified as a HTTP Url. > Added dependencies of libcurl, ssl, crypto & z to the Makefile. > = > = > Diffs > ----- > = > src/launcher/launcher.cpp 9bbae7e = > src/Makefile.am 1d108ab = > src/common/utils.hpp 5a88f17 = > = > Diff: https://reviews.apache.org/r/4119/diff > = > = > Testing > ------- > = > = > Thanks, > = > Florian > = > --===============3162180781678020777==--