incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Build updates (see description).
Date Mon, 12 Mar 2012 20:21:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/
-----------------------------------------------------------

(Updated 2012-03-12 20:21:47.750410)


Review request for mesos and Charles Reiss.


Changes
-------

For posterity, I've uploaded the final patch applied.


Summary
-------

Build updates:
  * Have libprocess only build a convenience library by default (so nothing gets installed).
  * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
  * Actually force build.cpp to get recompiled.
  * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed
libmesos.la in 'dependency_lib'.
  * Added leveldb to python/setup.py.in (given the previous).

NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory
created. It would be nice to eliminate that!


Diffs (updated)
-----

  configure.ac d61c893 
  src/Makefile.am 1137a3e 
  src/common/build.hpp 9dba632 
  src/common/build.cpp e7b43c4 
  src/python/native/proxy_scheduler.cpp bc0c43f 
  src/python/setup.py.in 472094e 
  third_party/libprocess/Makefile.am 48ee256 
  third_party/libprocess/configure.ac ace13e0 

Diff: https://reviews.apache.org/r/4187/diff


Testing
-------

make && make check && make install DESTDIR=/tmp/mesos


Thanks,

Benjamin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message