incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Re: Review Request: Build updates (see description).
Date Fri, 09 Mar 2012 00:36:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5762
-----------------------------------------------------------

Ship it!


LGTM.


third_party/libprocess/configure.ac
<https://reviews.apache.org/r/4187/#comment12557>

    I'd prefer to just remove this option.


- Charles


On 2012-03-08 23:47:37, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
> 
> (Updated 2012-03-08 23:47:37)
> 
> 
> Review request for mesos and Charles Reiss.
> 
> 
> Summary
> -------
> 
> Build updates:
>   * Have libprocess only build a convenience library by default (so nothing gets installed).
>   * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
>   * Actually force build.cpp to get recompiled.
>   * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed
libmesos.la in 'dependency_lib'.
>   * Added leveldb to python/setup.py.in (given the previous).
> 
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory
created. It would be nice to eliminate that!
> 
> 
> Diffs
> -----
> 
>   configure.ac d61c893 
>   src/Makefile.am 1137a3e 
>   src/common/build.cpp e7b43c4 
>   src/common/build.cpp.in PRE-CREATION 
>   src/python/native/proxy_scheduler.cpp bc0c43f 
>   src/python/setup.py.in 472094e 
>   third_party/libprocess/Makefile.am 48ee256 
>   third_party/libprocess/configure.ac ace13e0 
> 
> Diff: https://reviews.apache.org/r/4187/diff
> 
> 
> Testing
> -------
> 
> make && make check && make install DESTDIR=/tmp/mesos
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message