incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Re: Review Request: Adding support to launcher.cpp to retrieve files (executors) via HTTP
Date Fri, 02 Mar 2012 14:09:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4119/#review5539
-----------------------------------------------------------



src/launcher/launcher.cpp
<https://reviews.apache.org/r/4119/#comment11962>

    Check if this fails?



src/launcher/launcher.cpp
<https://reviews.apache.org/r/4119/#comment11964>

    Do you have some reason to believe that if this fails (e.g. connection closed before response
is complete), then CURLINFO_RESPONSE_CODE won't be 200?



src/launcher/launcher.cpp
<https://reviews.apache.org/r/4119/#comment11966>

    Check return value? (e.g. out of disk space/quota).


- Charles


On 2012-03-01 02:48:20, Florian Leibert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4119/
> -----------------------------------------------------------
> 
> (Updated 2012-03-01 02:48:20)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> Launcher can now retrieve an executor specified as a HTTP Url.
> Added dependencies of libcurl, ssl, crypto & z to the Makefile.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5ed41bf 
>   src/launcher/launcher.cpp 4422224 
> 
> Diff: https://reviews.apache.org/r/4119/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Florian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message