Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD3D69586 for ; Wed, 8 Feb 2012 22:19:45 +0000 (UTC) Received: (qmail 89981 invoked by uid 500); 8 Feb 2012 22:19:45 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 89949 invoked by uid 500); 8 Feb 2012 22:19:45 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 89934 invoked by uid 99); 8 Feb 2012 22:19:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2012 22:19:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6785F1C3407; Wed, 8 Feb 2012 22:19:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4322564762350436801==" MIME-Version: 1.0 Subject: Re: Review Request: Create utilities to collect information from the proc filesystem From: "Sam Whitlock" To: "Charles Reiss" , "Alex Degtiar" , "Sam Whitlock" , "mesos" Date: Wed, 08 Feb 2012 22:19:44 -0000 Message-ID: <20120208221944.16858.80585@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3050/ In-Reply-To: <20120207181430.16858.90495@reviews.apache.org> References: <20120207181430.16858.90495@reviews.apache.org> --===============4322564762350436801== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-02-07 18:14:30, Charles Reiss wrote: > > > = > Sam Whitlock wrote: > What target should these go into in Makefile.am? libmesos_no_third_pa= rty_la_SOURCES seems to be the one that all the source files are being adde= d to. > = > Charles Reiss wrote: > libmesos_no_third_party_la would be fine for the non-test targets. (= The test ones probably go into the mesos_tests_SOURCES.) > Because some of the monitoring stuff is linux-specific, should it be condit= ionally added to libmesos_no_third_party_la_SOURCES in the same way lxc_iso= lation_module.cpp is? It seems like all the hpp files are unconditionally added to libmesos_no_th= ird_party and linux-specific cpp files should only be added if OS_LINUX is = true. Is this correct? - Sam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review4868 ----------------------------------------------------------- On 2011-12-24 04:13:40, Alex Degtiar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > = > (Updated 2011-12-24 04:13:40) > = > = > Review request for mesos. > = > = > Summary > ------- > = > The first of several patches related to resource usage monitoring. This p= atch provides a collection of utilities for use on Linux for reading stats = from proc. It is used by both the lxc and proc resource collectors. > = > = > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > = > = > Diffs > ----- > = > src/monitoring/linux/proc_utils.cpp PRE-CREATION = > src/tests/Makefile.in ea943f7 = > src/tests/proc_utils_tests.cpp PRE-CREATION = > src/Makefile.in 516f128 = > src/monitoring/linux/proc_utils.hpp PRE-CREATION = > = > Diff: https://reviews.apache.org/r/3050/diff > = > = > Testing > ------- > = > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all = utility functions, and functions have been tested ad hoc. > = > = > Thanks, > = > Alex > = > --===============4322564762350436801==--