incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall" <>
Subject Re: Review Request: Additional History on Webui
Date Wed, 01 Feb 2012 04:03:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-02-01 04:03:33.220793)

Review request for mesos, Benjamin Hindman and Andy Konwinski.


The problem seemed to be that the default copy constructor for Executor was only copying the
pointers to the Tasks in launchedTasks but the destructor was deleting those objects. When
an Executor was shut down abnormally, so that there were still some Tasks in launchedTasks,
the copy of the Executor we're making to put in the completedExecutor deque tries to access
the pointers in launchedTasks and the objects aren't there anymore.

So, I'm not sure if this is the best solution, but I wrote a copy constructor for the Executor
class that copies the Task objects themselves, and that fixed it.


Added a framework history to the slave page, an executor history to the framework page, and
a task history to the executor page. Allows stdout and stderr of executors to be viewed after
they finish executing.

This addresses bug MESOS-8.

Diffs (updated)

  src/slave/constants.hpp f0c8679 
  src/slave/http.cpp f03815d 
  src/slave/slave.hpp b1a07e9 
  src/slave/slave.cpp 9b33a5a 
  src/webui/slave/executor.tpl dd53464 
  src/webui/slave/framework.tpl 9488da5 
  src/webui/slave/index.tpl 0f18de6 





  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message