incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Build third_party out of tarballs instead of distributing unpacked source
Date Wed, 01 Feb 2012 00:19:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3588/#review4725
-----------------------------------------------------------



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10445>

    s/move/Move and kill tab (or indentation).



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10446>

    Wrap for 80 characters please.



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10447>

    I've replaced '$(top_builddir)' with '..' everywhere else in the file.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10450>

    I'd love to see some documentation here explaining our strategy for third_party, and why
we decided to do it this way. Also, we need the license here too.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10448>

    Not used.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10449>

    Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10443>

    Wrap for 80 characters please (and everywhere else in this file).



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10442>

    Kill tab.


- Benjamin


On 2012-01-23 08:26:57, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3588/
> -----------------------------------------------------------
> 
> (Updated 2012-01-23 08:26:57)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> Builds third_party from tarballs instead of having us distribute the unpacked source.
> 
> To make it sane to review, this patch does not include the tarballs or the removal of
the original third_party directories. Everything but distribute-* should be put into tarballs
for this to work.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   Makefile.am f26e555 
>   configure.ac bda6769 
>   src/Makefile.am b8fc58e 
>   src/python/setup.py.in 07aaa58 
>   src/tests/base_zookeeper_test.cpp 872bffb 
>   third_party/Makefile.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/3588/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message