Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4AB09DCA for ; Sat, 28 Jan 2012 22:23:16 +0000 (UTC) Received: (qmail 52858 invoked by uid 500); 28 Jan 2012 22:23:16 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 52804 invoked by uid 500); 28 Jan 2012 22:23:15 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 52789 invoked by uid 99); 28 Jan 2012 22:23:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jan 2012 22:23:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C50441C00B6; Sat, 28 Jan 2012 22:23:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3363628640126347154==" MIME-Version: 1.0 Subject: Review Request: Initialize 'locked' member of Lock. From: "Charles Reiss" To: "Benjamin Hindman" Date: Sat, 28 Jan 2012 22:23:14 -0000 Message-ID: <20120128222314.8329.57625@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3689/ Cc: "mesos" , "Charles Reiss" --===============3363628640126347154== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3689/ ----------------------------------------------------------- Review request for mesos and Benjamin Hindman. Summary ------- The 'locked' member variable of the mesos::internal::Lock utility class was= not initialized. I found this through valgrind. Diffs ----- src/common/lock.cpp 9000c11 = Diff: https://reviews.apache.org/r/3689/diff Testing ------- Thanks, Charles --===============3363628640126347154==--