Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D154792AD for ; Wed, 25 Jan 2012 19:12:44 +0000 (UTC) Received: (qmail 91382 invoked by uid 500); 25 Jan 2012 19:12:44 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 91345 invoked by uid 500); 25 Jan 2012 19:12:44 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 91329 invoked by uid 99); 25 Jan 2012 19:12:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2012 19:12:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CF97A1C206F; Wed, 25 Jan 2012 19:12:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6266069615316087860==" MIME-Version: 1.0 Subject: Re: Review Request: Use distribute egg in python tests From: "Charles Reiss" To: "Charles Reiss" , "mesos" , "Benjamin Hindman" Date: Wed, 25 Jan 2012 19:12:43 -0000 Message-ID: <20120125191243.8329.96229@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3589/ In-Reply-To: <20120124212945.8329.75014@reviews.apache.org> References: <20120124212945.8329.75014@reviews.apache.org> --===============6266069615316087860== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 18 > > > > > > What's the benefit of using 'echo' rather than 'ls' to expand the w= ildcards? I'm happy using 'echo', but then I'd prefer that we do that every= where in this file (and others) for consistency. If the file doesn't exist ls will return the empty string (and print a mess= age to stderr), so the error message won't make sense. Changed both files t= o use echo. > On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 43 > > > > > > I had intentionally removed this. If it's needed, please provide a = comment as to why we it's necessary. Re-removed. > On 2012-01-24 21:29:45, Benjamin Hindman wrote: > > src/examples/python/test-executor.in, line 45 > > > > > > Please wrap this at 'exec ${PYTHON} ...', here and in the other fil= e too. Done. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3589/#review4563 ----------------------------------------------------------- On 2012-01-25 19:12:32, Charles Reiss wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3589/ > ----------------------------------------------------------- > = > (Updated 2012-01-25 19:12:32) > = > = > Review request for mesos. > = > = > Summary > ------- > = > Fixes MESOS-130. > = > = > This addresses bug MESOS-130. > https://issues.apache.org/jira/browse/MESOS-130 > = > = > Diffs > ----- > = > src/examples/python/test-executor.in 7cf2e27 = > src/examples/python/test-framework.in 2a557cf = > = > Diff: https://reviews.apache.org/r/3589/diff > = > = > Testing > ------- > = > = > Thanks, > = > Charles > = > --===============6266069615316087860==--