Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
	boundary="===============5390642653293247627=="
MIME-Version: 1.0
Subject: Re: Review Request: Link against libjvm.so with rpaths on Linux.
From: "Charles Reiss" <woggling@gmail.com>
To: "Charles Reiss" <woggling@gmail.com>,
	"mesos" <mesos-dev@incubator.apache.org>,
	"Benjamin Hindman" <benh@berkeley.edu>
Date: Tue, 24 Jan 2012 08:36:02 -0000
Message-ID: <20120124083602.8384.63655@reviews.apache.org>
In-Reply-To: <20120124083336.8329.32055@reviews.apache.org>
References: <20120124083336.8329.32055@reviews.apache.org>

--===============5390642653293247627==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3580/
-----------------------------------------------------------

(Updated 2012-01-24 08:36:02.307999)


Review request for mesos.


Changes
-------

(This time without miscorrecting ../$(SETUPTOOLS) to $(SETUPTOOLS).)


Summary
-------

On Linux, I've needed to build with -Wl,-rpath to nicely link against -ljvm=
. We should do something like this automatically.

This patch (on Linux only) uses -Wl,-ljvm instead of -ljvm to link -ljvm so=
 libtool doesn't add it to dependency_libs [*]. Besides hopefully being unn=
ecessary, it fails to link things linked against that libtool library becau=
se libtool doesn't add the rpath for the java libraries (even if I specify =
it with -R). This also requires that the flags be added on libmesos.la and =
uses the assumption that libmesos.la is linked dynamically.

[*] Things added to dependency_libs are automatically linked into any execu=
tables linking against the library; this would be fine (and would make sens=
e if our header files might contain inline functions that call JNI_* calls)=
 if the -R settings were properly passed through, but libtool does not appe=
ar to do this.


This addresses bug MESOS-127.
    https://issues.apache.org/jira/browse/MESOS-127


Diffs (updated)
-----

  configure.ac bda6769 =

  src/Makefile.am b8fc58e =


Diff: https://reviews.apache.org/r/3580/diff


Testing
-------


Thanks,

Charles


--===============5390642653293247627==--