incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Wilkerson <>
Subject as you are using centralized revision control, how exactly do you want changes reported?
Date Mon, 02 Jan 2012 00:54:55 GMT
File src/examples/long_lived_framework.cpp has an extra member in
MyScheduler that is unused and distracting: string uri.

If the code were on github I would check in the patch and then send
you a pull request.  However given that your main codebase is in svn
which requires membership to the club, I'm wondering how you handle
bug-fixes like this.


diff -r 2d7a0804bbde src/examples/long_lived_framework.cpp
--- a/src/examples/long_lived_framework.cpp	Sat Dec 31 20:05:41 2011 -0800
+++ b/src/examples/long_lived_framework.cpp	Sun Jan 01 16:52:21 2012 -0800
@@ -129,7 +129,6 @@
                      const string& message) {}

-  string uri;
   int tasksLaunched;

Builds fine without it.

g++ -O2 -fno-strict-aliasing -fPIC  -D_XOPEN_SOURCE -g -I../../include
-I../../include -I../../third_party/boost-1.37.0
-I../../third_party/glog-0.3.1/src -I../../third_party/glog-0.3.1/src
-I../../third_party/protobuf-2.3.0/src -I../../third_party/libprocess
-I../../third_party/zookeeper-3.3.1/src/c/generated -MMD -MP -o
../../bin/examples/long-lived-framework long_lived_framework.cpp
../../lib/libmesos_sched.a  -L../../third_party/glog-0.3.1/.libs
-L../../third_party/zookeeper-3.3.1/src/c/.libs  -lprotobuf -lglog
-lprocess -lev -lpthread -ldl -lzookeeper_mt
make -C java
make[1]: Nothing to be done for `default'.
make -C python
make[1]: Nothing to be done for `default'.

Compilation finished at Sun Jan  1 16:50:58

View raw message