incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <>
Subject Re: Review Request: Link against with rpaths on Linux.
Date Tue, 24 Jan 2012 08:36:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-01-24 08:36:02.307999)

Review request for mesos.


(This time without miscorrecting ../$(SETUPTOOLS) to $(SETUPTOOLS).)


On Linux, I've needed to build with -Wl,-rpath to nicely link against -ljvm. We should do
something like this automatically.

This patch (on Linux only) uses -Wl,-ljvm instead of -ljvm to link -ljvm so libtool doesn't
add it to dependency_libs [*]. Besides hopefully being unnecessary, it fails to link things
linked against that libtool library because libtool doesn't add the rpath for the java libraries
(even if I specify it with -R). This also requires that the flags be added on
and uses the assumption that is linked dynamically.

[*] Things added to dependency_libs are automatically linked into any executables linking
against the library; this would be fine (and would make sense if our header files might contain
inline functions that call JNI_* calls) if the -R settings were properly passed through, but
libtool does not appear to do this.

This addresses bug MESOS-127.

Diffs (updated)
----- bda6769 
  src/ b8fc58e 





  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message