Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5A9277F6 for ; Wed, 21 Dec 2011 03:24:40 +0000 (UTC) Received: (qmail 75904 invoked by uid 500); 21 Dec 2011 03:24:40 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 75865 invoked by uid 500); 21 Dec 2011 03:24:39 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 75850 invoked by uid 99); 21 Dec 2011 03:24:39 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2011 03:24:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A5271C3085; Wed, 21 Dec 2011 03:24:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8102756727379873535==" MIME-Version: 1.0 Subject: Re: Review Request: Create utilities to collect information from the proc filesystem From: "Alex Degtiar" To: "Benjamin Hindman" , "Alex Degtiar" , "mesos" Date: Wed, 21 Dec 2011 03:24:39 -0000 Message-ID: <20111221032439.18123.81521@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3050/ In-Reply-To: <20111208184830.25014.71463@reviews.apache.org> References: <20111208184830.25014.71463@reviews.apache.org> --===============8102756727379873535== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > Also, as discussed, I created a monitoring/linux folder to put all linux-sp= ecific source files. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, line 33 > > > > > > Brace on newline. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 43 > > > > > > Brace on newline. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 60 > > > > > > Double newline between functions. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, lines 38-39 > > > > > > Use seconds or milliseconds _abstraction_ from common/seconds.hpp. Done. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.hpp, line 53 > > > > > > Seconds or milliseconds type, here and everywhere else. Done. Went with seconds for consistency with rest of Mesos. > On 2011-12-08 18:48:30, Benjamin Hindman wrote: > > src/monitoring/proc_utils.cpp, line 76 > > > > > > Add more spaces between logical blocks. Done. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review3745 ----------------------------------------------------------- On 2011-12-08 00:00:32, Alex Degtiar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > = > (Updated 2011-12-08 00:00:32) > = > = > Review request for mesos. > = > = > Summary > ------- > = > The first of several patches related to resource usage monitoring. This p= atch provides a collection of utilities for use on Linux for reading stats = from proc. It is used by both the lxc and proc resource collectors. > = > = > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > = > = > Diffs > ----- > = > src/tests/Makefile.in ea943f7 = > src/tests/proc_utils_tests.cpp PRE-CREATION = > src/monitoring/proc_utils.cpp PRE-CREATION = > src/Makefile.in 516f128 = > src/monitoring/proc_utils.hpp PRE-CREATION = > = > Diff: https://reviews.apache.org/r/3050/diff > = > = > Testing > ------- > = > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all = utility functions, and functions have been tested ad hoc. > = > = > Thanks, > = > Alex > = > --===============8102756727379873535==--