Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40F2F70A3 for ; Thu, 8 Dec 2011 00:00:33 +0000 (UTC) Received: (qmail 27832 invoked by uid 500); 8 Dec 2011 00:00:33 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 27805 invoked by uid 500); 8 Dec 2011 00:00:33 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 27795 invoked by uid 99); 8 Dec 2011 00:00:33 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2011 00:00:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BBBAB1C2EFD; Thu, 8 Dec 2011 00:00:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5095702483525297838==" MIME-Version: 1.0 Subject: Re: Review Request: Create utilities to collect information from the proc filesystem From: "Alex Degtiar" To: "Charles Reiss" , "Alex Degtiar" , "mesos" Date: Thu, 08 Dec 2011 00:00:32 -0000 Message-ID: <20111208000032.27036.69873@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3050/ In-Reply-To: <20111207070806.25014.74355@reviews.apache.org> References: <20111207070806.25014.74355@reviews.apache.org> --===============5095702483525297838== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/ ----------------------------------------------------------- (Updated 2011-12-08 00:00:32.699023) Review request for mesos. Changes ------- I've address the comments and updated the diff. PTAL. Summary ------- The first of several patches related to resource usage monitoring. This pat= ch provides a collection of utilities for use on Linux for reading stats fr= om proc. It is used by both the lxc and proc resource collectors. This addresses bug MESOS-89. https://issues.apache.org/jira/browse/MESOS-89 Diffs (updated) ----- src/tests/Makefile.in ea943f7 = src/tests/proc_utils_tests.cpp PRE-CREATION = src/monitoring/proc_utils.cpp PRE-CREATION = src/Makefile.in 516f128 = src/monitoring/proc_utils.hpp PRE-CREATION = Diff: https://reviews.apache.org/r/3050/diff Testing ------- Sanity tests have been written in src/tests/proc_utils_tests.cpp for all ut= ility functions, and functions have been tested ad hoc. Thanks, Alex --===============5095702483525297838==--