Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Wed, 21 Dec 2011 03:25:38 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <1843711248.34056.1324437938570.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1672910518.36645.1321484751851.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-89) create utilities to collect
 information from the proc filesystem
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173818#comment-13173818 ] 

jiraposter@reviews.apache.org commented on MESOS-89:
----------------------------------------------------


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  >

Also, as discussed, I created a monitoring/linux folder to put all linux-specific source files.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.hpp, line 33
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line33>
bq.  >
bq.  >     Brace on newline.

Done.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.cpp, line 43
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line43>
bq.  >
bq.  >     Brace on newline.

Done.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.cpp, line 60
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line60>
bq.  >
bq.  >     Double newline between functions.

Done.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.hpp, lines 38-39
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line38>
bq.  >
bq.  >     Use seconds or milliseconds _abstraction_ from common/seconds.hpp.

Done.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.hpp, line 53
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63110#file63110line53>
bq.  >
bq.  >     Seconds or milliseconds type, here and everywhere else.

Done. Went with seconds for consistency with rest of Mesos.


bq.  On 2011-12-08 18:48:30, Benjamin Hindman wrote:
bq.  > src/monitoring/proc_utils.cpp, line 76
bq.  > <https://reviews.apache.org/r/3050/diff/2/?file=63111#file63111line76>
bq.  >
bq.  >     Add more spaces between logical blocks.

Done.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3050/#review3745
-----------------------------------------------------------


On 2011-12-08 00:00:32, Alex Degtiar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3050/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-08 00:00:32)
bq.  
bq.  
bq.  Review request for mesos.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The first of several patches related to resource usage monitoring. This patch provides a collection of utilities for use on Linux for reading stats from proc. It is used by both the lxc and proc resource collectors.
bq.  
bq.  
bq.  This addresses bug MESOS-89.
bq.      https://issues.apache.org/jira/browse/MESOS-89
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/tests/Makefile.in ea943f7 
bq.    src/tests/proc_utils_tests.cpp PRE-CREATION 
bq.    src/monitoring/proc_utils.cpp PRE-CREATION 
bq.    src/Makefile.in 516f128 
bq.    src/monitoring/proc_utils.hpp PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3050/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Sanity tests have been written in src/tests/proc_utils_tests.cpp for all utility functions, and functions have been tested ad hoc.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alex
bq.  
bq.


> create utilities to collect information from the proc filesystem
> ----------------------------------------------------------------
>
>                 Key: MESOS-89
>                 URL: https://issues.apache.org/jira/browse/MESOS-89
>             Project: Mesos
>          Issue Type: Sub-task
>          Components: slave
>         Environment: This is specific to Linux, as OS X does not have a proc filesystem.
>            Reporter: Sam Whitlock
>            Assignee: Alex Degtiar
>            Priority: Minor
>              Labels: monitoring
>
> This is a utility for MESOS-38 https://issues.apache.org/jira/browse/MESOS-38
> Create a collection of utilities to read information from the proc filesystem. This will be used in MESOS-38 to collect most of the information for the process-based isolation usage reporting mechanism. These utilities will also be used for certain functionality in monitoring lxc-based isolation because not all of the information needed is available via the cgroup interface, such as the start time of the container.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira