Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Wed, 23 Nov 2011 07:03:44 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <454795703.5354.1322031824190.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <681148080.49333.1320207872282.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-56) Resources of tasks queued during
 executor launch not always accounted for
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155729#comment-13155729 ] 

jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------


bq.  On 2011-11-23 06:49:29, Benjamin Hindman wrote:
bq.  > src/tests/utils.hpp, line 269
bq.  > <https://reviews.apache.org/r/2669/diff/4/?file=59546#file59546line269>
bq.  >
bq.  >     I think this is an orphaned line ...

Removed.


- Charles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3468
-----------------------------------------------------------


On 2011-11-23 07:02:41, Charles Reiss wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2669/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-23 07:02:41)
bq.  
bq.  
bq.  Review request for mesos.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.  
bq.  
bq.  This addresses bug MESOS-56.
bq.      https://issues.apache.org/jira/browse/MESOS-56
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/slave/slave.cpp de5716c 
bq.    src/tests/master_tests.cpp 2438114 
bq.    src/tests/utils.hpp 89af7f3 
bq.  
bq.  Diff: https://reviews.apache.org/r/2669/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modification to MasterTest included.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.


> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
>                 Key: MESOS-56
>                 URL: https://issues.apache.org/jira/browse/MESOS-56
>             Project: Mesos
>          Issue Type: Bug
>          Components: isolation, slave
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira