Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Mon, 14 Nov 2011 20:26:54 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <384220974.27939.1321302414799.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2031549577.4249.1314072089403.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-33) Fix slave webui representation and
 pass back to master.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149877#comment-13149877 ] 

jiraposter@reviews.apache.org commented on MESOS-33:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3220
-----------------------------------------------------------


src/slave/slave.cpp
<https://reviews.apache.org/r/2770/#comment7171>

    Feel free to just stick all of conf.get(...) into the set_webui_port parameter.


- Benjamin


On 2011-11-08 02:46:08, Sumedh Sawant wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2770/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-08 02:46:08)
bq.  
bq.  
bq.  Review request for mesos, Benjamin Hindman and Andy Konwinski.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
bq.  
bq.  
bq.  This addresses bug MESOS-33.
bq.      https://issues.apache.org/jira/browse/MESOS-33
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/mesos.proto 33248ec 
bq.    src/master/http.cpp 47caf48 
bq.    src/slave/slave.cpp de5716c 
bq.    src/webui/master/index.tpl 16e3446 
bq.  
bq.  Diff: https://reviews.apache.org/r/2770/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Sumedh
bq.  
bq.


> Fix slave webui representation and pass back to master.
> -------------------------------------------------------
>
>                 Key: MESOS-33
>                 URL: https://issues.apache.org/jira/browse/MESOS-33
>             Project: Mesos
>          Issue Type: Bug
>          Components: ec2, master, slave, webui
>            Reporter: Benjamin Hindman
>            Assignee: Sumedh Sawant
>
> A slave needs to report both it's webui hostname AND it's port back to the master so that it can correctly display them in it's own webui.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira