Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Mon, 14 Nov 2011 23:13:52 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <1412727586.28754.1321312432715.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1747076538.53533.1320277292278.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-59) Test macros in tests/utils.hpp aren't
 robust
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150063#comment-13150063 ] 

jiraposter@reviews.apache.org commented on MESOS-59:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/
-----------------------------------------------------------

(Updated 2011-11-14 23:13:38.136855)


Review request for mesos.


Summary
-------

See description of bugs in MESOS-59.


This addresses bug MESOS-59.
    https://issues.apache.org/jira/browse/MESOS-59


Diffs (updated)
-----

  src/tests/utils.hpp 02772f7 

Diff: https://reviews.apache.org/r/2685/diff


Testing
-------


Thanks,

Charles


> Test macros in tests/utils.hpp aren't robust
> --------------------------------------------
>
>                 Key: MESOS-59
>                 URL: https://issues.apache.org/jira/browse/MESOS-59
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>            Priority: Trivial
>
> The EXPECT_MSG macro in tests/utils.hpp won't work if the MockFilter object is called anythig but filter (because it's the method and macro argument name).
> The WAIT_UNTIL macro in tests/utils.hpp doesn't put parens around its argument so something like WAIT_UNTIL(&trigger) will always return immediately instead of causing a compilation error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira