incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From " (Commented) (JIRA)" <>
Subject [jira] [Commented] (MESOS-59) Test macros in tests/utils.hpp aren't robust
Date Mon, 14 Nov 2011 20:32:54 GMT

] commented on MESOS-59:

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-11-14 20:31:10.001668)

Review request for mesos.


See description of bugs in MESOS-59.

This addresses bug MESOS-59.

Diffs (updated)

  src/tests/utils.hpp 02772f7 





> Test macros in tests/utils.hpp aren't robust
> --------------------------------------------
>                 Key: MESOS-59
>                 URL:
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>            Priority: Trivial
> The EXPECT_MSG macro in tests/utils.hpp won't work if the MockFilter object is called
anythig but filter (because it's the method and macro argument name).
> The WAIT_UNTIL macro in tests/utils.hpp doesn't put parens around its argument so something
like WAIT_UNTIL(&trigger) will always return immediately instead of causing a compilation

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message