Mailing-List: contact lucy-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: lucy-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4F6F6D20.4020206@aevum.de>
Date: Sun, 25 Mar 2012 21:08:16 +0200
From: Nick Wellnhofer <wellnhofer@aevum.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: lucy-dev@incubator.apache.org
References: <4F6B792D.1010906@aevum.de>
 <CAAS6=7hkwsQt=a=9kMPiMKhtT02KOhpxUtzEJ47OhCa-GtMieQ@mail.gmail.com>
 <4F6DB1F7.4040504@aevum.de>
 <CAAS6=7iGz+LU6P9oNwwf5HQeWz8GzBtHKxrLR4ubAvQr8gSbeg@mail.gmail.com>
In-Reply-To: 
 <CAAS6=7iGz+LU6P9oNwwf5HQeWz8GzBtHKxrLR4ubAvQr8gSbeg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [lucy-dev] New branch LUCY-215-cf-extensions

On 25/03/2012 20:33, Marvin Humphrey wrote:
> On Sat, Mar 24, 2012 at 4:37 AM, Nick Wellnhofer<wellnhofer@aevum.de>  wrote:
>
>> One thing is core/Lucy/Util/ToolSet.h, which is included from every
>> Clownfish .c file. I'm not sure what's the best way to handle that.
>
> For the record, I grepped trunk/clownfish for "ToolSet" and came up empty.  I
> believe it's used only in Lucy-specific hand-coded .c files in core/, not in
> CFC-autogenerated files.  Right?

Yes, it's just a utility file used in the Lucy .c files.

> Nevertheless, there is still a potential problem in that .cfh files are
> allowed to contain arbitrary C code, and this scenario could have arisen:
>
>      class Lucy::Foo::Bar {
>          ...
>      }
>
>      __C__
>      #include "Lucy/Util/ToolSet.h"
>      __END_C__
>
> To address that scenario, I believe that the best approach is to install all
> .h files in core/ along with all .cfh files underneath Clownfish/_include.

OK, makes sense.

Nick