Mailing-List: contact lucy-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: lucy-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Mon, 14 Nov 2011 23:02:26 -0800
From: Marvin Humphrey <marvin@rectangular.com>
To: lucy-dev@incubator.apache.org
Message-ID: <20111115070226.GA27412@rectangular.com>
References: <A5014E17-1661-48DF-9D34-8A01810235B8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A5014E17-1661-48DF-9D34-8A01810235B8@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: Re: [lucy-dev] [patch] for ClusterSearcher.pm

On Mon, Nov 14, 2011 at 10:49:33PM -0800, Dan Markham wrote:
> Non-Blocking for mortals.

LOL

The arg's backwards (should be Blocking => 0) -- it's the unusual case where
we need to actively turn something off to get what we want.  After that,
applied as r1202069, thanks for the improvement!

http://svn.apache.org/viewvc?view=revision&revision=1202069

Marvin Humphrey

> Index: ClusterSearcher.pm
> ===================================================================
> --- ClusterSearcher.pm  (revision 1202059)
> +++ ClusterSearcher.pm  (working copy)
> @@ -35,7 +35,6 @@
>  
>  use IO::Socket::INET;
>  use IO::Select;
> -use Fcntl qw( F_GETFL F_SETFL O_NONBLOCK );
>  
>  sub new {
>      my ( $either, %args ) = @_;
> @@ -54,12 +53,9 @@
>          my $sock = IO::Socket::INET->new(
>              PeerAddr => $shard,
>              Proto    => 'tcp',
> +            Blocking => 1,
>          );
>          confess("No socket: $!") unless $sock;
> -        my $flags = fcntl( $sock, F_GETFL, 0 )
> -            or confess "Can't get socket flags: $!";
> -        fcntl( $sock, F_SETFL, $flags | O_NONBLOCK )
> -            or confess "Can't set socket flags: $!";
>          push @$socks, $sock;
>      }
> 
> 
> 
> -Dan