incubator-kato-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From monte...@apache.org
Subject svn commit: r890866 - in /incubator/kato/trunk/org.apache.kato: kato.hprof.api/src/main/java/org/apache/kato/hprof/java/ kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/
Date Tue, 15 Dec 2009 16:21:28 GMT
Author: monteith
Date: Tue Dec 15 16:21:28 2009
New Revision: 890866

URL: http://svn.apache.org/viewvc?rev=890866&view=rev
Log:
Fix missing NPE and boolean array reading.

Modified:
    incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaObjectArrayImpl.java
    incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaPrimitiveArrayImpl.java
    incubator/kato/trunk/org.apache.kato/kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/HProfFile.java

Modified: incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaObjectArrayImpl.java
URL: http://svn.apache.org/viewvc/incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaObjectArrayImpl.java?rev=890866&r1=890865&r2=890866&view=diff
==============================================================================
--- incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaObjectArrayImpl.java
(original)
+++ incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaObjectArrayImpl.java
Tue Dec 15 16:21:28 2009
@@ -62,7 +62,7 @@
 		}
 
 		if (dst == null) {
-			throw new IllegalArgumentException("Destination array must not be null");
+			throw new NullPointerException("Destination array must not be null");
 		}
 		if (!dst.getClass().isArray()) {
 			throw new IllegalArgumentException("Destination array must be an array, not "+dst.getClass().getName());
		

Modified: incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaPrimitiveArrayImpl.java
URL: http://svn.apache.org/viewvc/incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaPrimitiveArrayImpl.java?rev=890866&r1=890865&r2=890866&view=diff
==============================================================================
--- incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaPrimitiveArrayImpl.java
(original)
+++ incubator/kato/trunk/org.apache.kato/kato.hprof.api/src/main/java/org/apache/kato/hprof/java/JavaPrimitiveArrayImpl.java
Tue Dec 15 16:21:28 2009
@@ -52,7 +52,7 @@
 		}
 
 		if (dst == null) {
-			throw new IllegalArgumentException("Destination array must not be null");
+			throw new NullPointerException("Destination array must not be null");
 		}
 		if (!dst.getClass().isArray()) {
 			throw new IllegalArgumentException("Destination array must be an array, not "+dst.getClass().getName());
		

Modified: incubator/kato/trunk/org.apache.kato/kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/HProfFile.java
URL: http://svn.apache.org/viewvc/incubator/kato/trunk/org.apache.kato/kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/HProfFile.java?rev=890866&r1=890865&r2=890866&view=diff
==============================================================================
--- incubator/kato/trunk/org.apache.kato/kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/HProfFile.java
(original)
+++ incubator/kato/trunk/org.apache.kato/kato.hprof.reader/src/main/java/org/apache/kato/hprof/datalayer/HProfFile.java
Tue Dec 15 16:21:28 2009
@@ -1132,7 +1132,7 @@
 
 		@Override
 		public boolean getBooleanElement(int index) {
-			return getByteElement(index) == 0;
+			return getByteElement(index) != 0;
 		}
 		
 		@Override



Mime
View raw message