incubator-kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swapnil Ghike (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-622) Create mbeans per client
Date Wed, 28 Nov 2012 01:26:58 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Swapnil Ghike updated KAFKA-622:
--------------------------------

    Attachment: kafka-622-v3.patch

1. I see your point, that's good to know. Now using a case class with three constructor arguments.
Using two separate arguments String and TopicAndPartition would mean that the key of the stats
Pool will be a touple. 
2. Yup.
3.1 Yes, the primary constructor is only used for unit testing. So we can skip clientId validation.
3.2, 3.3 using a case class object to avoid using a tuple as the constructor argument.
4. Added a comment above both methods, also changed the order of arguments so that broker
is the second argument in both methods.
5. Aye.
6. Changed it to clientId = props.getString("clientid",SyncProducerConfig.DefaultClientId)
7. Aggregation of ConsumerRequestStats at the ZookeeperConsumerConnector level will need us
to pass an aggregator object to the constructor of SimpleConsumer. Then we will either need
to provide this aggregator object a default value in the constructor because we can't expect
the users of SimpleConsumer to know how to instantiate that object. Thoughts?
8. ConsumerTopicStat.scala was modified and renamed to ConsumerTopicStats.scala. Due to svn
issues, deleted the old file, added the modified file as a new file. 

                
> Create mbeans per client 
> -------------------------
>
>                 Key: KAFKA-622
>                 URL: https://issues.apache.org/jira/browse/KAFKA-622
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: bugs, improvement
>             Fix For: 0.8
>
>         Attachments: kafka-622-v1.patch, kafka-622-v2.patch, kafka-622-v3.patch
>
>
> Currently we create one mbean of each type for a given mbean server, regardless of the
number of clients. We should create MBeans per client for both producer and consumer. To do
that we need to introduce clientId in mbean names.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message