incubator-kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-197) Embedded consumer doesn't shut down if the server can't start
Date Mon, 05 Dec 2011 03:55:39 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162587#comment-13162587
] 

Jay Kreps commented on KAFKA-197:
---------------------------------

I don't think we want to call halt(), that is like kill -9 the process. I think we want the
logs to flush and shutdown gracefully. Can't we just do a graceful shutdown on both the server
and the embedded consumer?
                
> Embedded consumer doesn't shut down if the server can't start
> -------------------------------------------------------------
>
>                 Key: KAFKA-197
>                 URL: https://issues.apache.org/jira/browse/KAFKA-197
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.7
>            Reporter: Jun Rao
>             Fix For: 0.7.1
>
>         Attachments: KAFKA-197.patch
>
>
> If a broker embeds a consumer and the broker itself doesn't start (e.g., conflicting
broker id in ZK), the embedded consumer is still running. In this case, we should probably
shut down the embedded consumer too.
> To do this, we need to either throw an exception or return an error in KafkaServer.startup
and act accordingly in KafkaServerStartable.startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message