incubator-jspwiki-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Foster Schucker <Fos...@Schucker.org>
Subject Re: Current nightly fails on Geronimo 2.1.3
Date Thu, 12 Mar 2009 18:24:42 GMT
+1 providing something catches the exception and DOES something with 
it.  Just catching and returning null is worse.

Harry Metske wrote:

>+1
>
>
>
>2009/3/12 Janne Jalkanen <Janne.Jalkanen@ecyrd.com>
>
>  
>
>>Simple enough reason: getPage(WikiName,int) is not catching the
>>PathNotFoundException - look at the catch clause in getPage(WikiName) ;-).
>> It should do that and return null.
>>
>>My bad, sorry!
>>
>>(A general question, should we start throwing something like
>>PageNotFoundExceptions as opposed to returning nulls? That would encourage a
>>bit safer coding and would eliminate a number of if(getPage() == null) tests
>>across the codebase.)
>>
>>/Janne
>>
>>    
>>


Mime
View raw message