incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Pablo Santos Rodríguez <juanpablo.san...@gmail.com>
Subject Re: two unused variables reported by Sonar
Date Wed, 17 Jul 2013 22:39:52 GMT
Hi Glen,

didn't had the time to take a deep look into this yet, but seems to me
remains of old code. If you give a couple of days I'll try to confirm


br,
juan pablo

On Mon, Jul 15, 2013 at 10:49 PM, Glen Mazza <glen.mazza@gmail.com> wrote:

> Folks, Sonar is complaining[1] about two variables that are assigned but
> never being read within JSPWiki:
>
> gmazza@gmazza-E527:/media/**work1/opensource/jspwiki$ grep
> "m_useRelativeURLStyle" .
>
> ./jspwiki-war/src/main/java/**org/apache/wiki/url/**DefaultURLConstructor.java:
> protected boolean          m_useRelativeURLStyle = true;
> ./jspwiki-war/src/main/java/**org/apache/wiki/url/**DefaultURLConstructor.java:
> m_useRelativeURLStyle = "relative".equals( properties.getProperty(
> WikiEngine.PROP_REFSTYLE,
>
> gmazza@gmazza-E527:/media/**work1/opensource/jspwiki$ grep
> "m_enablePlugins" .
>
> ./jspwiki-war/src/main/java/**org/apache/wiki/render/**WikiRenderer.java:
> protected boolean         m_enablePlugins = true;
> ./jspwiki-war/src/main/java/**org/apache/wiki/render/**WikiRenderer.java:
> m_enablePlugins = toggle;
>
> Anybody know if these have an external purpose?  One file,
> ./jspwiki-war/src/main/config/**doc/APIChangesFrom2.4.html, mentions that
> m_enablePlugins was deleted from JSPWiki 2.4 (in class com.ecyrd.jspwiki.*
> *TranslatorReader).  I have no problem deleting these two variables and
> putting them back in later if we determine a use for them.
>
> Regards,
> Glen
>
> [1] https://analysis.apache.org/**drilldown/issues/org.apache.**
> jspwiki:jspwiki-builder?**severity=INFO<https://analysis.apache.org/drilldown/issues/org.apache.jspwiki:jspwiki-builder?severity=INFO>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message