incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brushed (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JSPWIKI-775) saving a page without supplying a change note will render a "null" change note in PageInfo.jsp
Date Tue, 23 Apr 2013 18:33:15 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639365#comment-13639365
] 

brushed commented on JSPWIKI-775:
---------------------------------

The proposed solution adds changenote attributes, even if no changenotes were entered.  I
believe it is better to avoid this.

An alternative way to solve the issue is to modify InfoContent.jsp


Modify around line 224:
{code}
         <td class="changenote">
           <% String changenote = (String) currentPage.getAttribute( WikiPage.CHANGENOTE
);  %>
		   <%= (changenote==null) ? "" : changenote  %>
         </td>
{code}

Modify around line 376:
{code}
      <td class='changenote'>
        <% String changenote = (String) att.getAttribute( WikiPage.CHANGENOTE ); %>
		<%= (changenote==null) ? "" : changenote  %>
      </td>
{code}


dirk

                
> saving a page without supplying a change note will render a "null" change note in PageInfo.jsp
> ----------------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-775
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-775
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.9.1
>         Environment: Ubuntu 12.04
> OpenJDK 7
> Tomcat 7.0.37
>            Reporter: Harry Metske
>            Priority: Minor
>
> Create a new page, or update an existing page, and do not provide a change note while
saving it.
> Go to the Info Tab to see the revisions, and you will see a change note "null".
> I would expect the change note to be empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message