incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Pablo Santos Rodríguez (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JSPWIKI-775) saving a page without supplying a change note will render a "null" change note in PageInfo.jsp
Date Mon, 22 Apr 2013 20:47:15 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638411#comment-13638411
] 

Juan Pablo Santos Rodríguez commented on JSPWIKI-775:
-----------------------------------------------------

proposed change:

{code:title=Edit.jsp, lines 161-168}
        if( changenote != null && changenote.length() > 0 )
        {
            modifiedPage.setAttribute( WikiPage.CHANGENOTE, changenote );
        }
        else
        {
            modifiedPage.removeAttribute( WikiPage.CHANGENOTE );
        }
{code}

with:

{code:title=Edit.jsp, lines 161-168}
        if( changenote != null && changenote.length() > 0 )
        {
            modifiedPage.setAttribute( WikiPage.CHANGENOTE, changenote );
        }
        else
        {
            modifiedPage.setAttribute( WikiPage.CHANGENOTE, "" );
        }
{code}

thoughts?
                
> saving a page without supplying a change note will render a "null" change note in PageInfo.jsp
> ----------------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-775
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-775
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.9.1
>         Environment: Ubuntu 12.04
> OpenJDK 7
> Tomcat 7.0.37
>            Reporter: Harry Metske
>            Priority: Minor
>
> Create a new page, or update an existing page, and do not provide a change note while
saving it.
> Go to the Info Tab to see the revisions, and you will see a change note "null".
> I would expect the change note to be empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message