Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Date: Thu, 31 Jan 2013 19:51:15 +0000 (UTC)
From: "Paul Cowan (JIRA)" <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Message-ID: <JIRA.12630198.1359661252422.225005.1359661875613@arcas>
In-Reply-To: <JIRA.12630198.1359661252422@arcas>
References: <JIRA.12630198.1359661252422@arcas>
Subject: [jira] [Updated] (JSPWIKI-759) Resin 4 Compatibility
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JSPWIKI-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Cowan updated JSPWIKI-759:
-------------------------------

    Environment: 
OSX 10.8.2, Oracle Java JDK 1.7.0_09, Resin Pro 4.0.34


  was:
OSX 10.8.2, Oracle Java JDK 1.7.0_09


        Summary: Resin 4 Compatibility  (was: Resin 4 Compatability)
    
> Resin 4 Compatibility
> ---------------------
>
>                 Key: JSPWIKI-759
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-759
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Servlet Container/Java compatibility
>    Affects Versions: 2.9
>         Environment: OSX 10.8.2, Oracle Java JDK 1.7.0_09, Resin Pro 4.0.34
>            Reporter: Paul Cowan
>         Attachments: patch.txt
>
>
> I am an engineer for Caucho on the Resin Application Server, and was testing JSPWiki on Resin version 4.0.34.  I would like to submit 2 fixes to enable JSPWiki to run better on Resin 4:
> #1. JSPWiki is calling getOutputStream after getWriter().  The servlet spec dictates we throw IllegalStateException for this situation.  I see JSPWiki already has handling in UtilJ2eeCompat to use an OutputStream rather than a Writer depending on the container.  The Resin check should have "useStream = true".
> #2. As a consequence of #1, JSPWiki serves empty content.  This is due to buffering inside the PrintWriter used by WikiJSPFilter.ByteArrayResponseWrapper.  The PrintWriter is never flushed when toString() is called on ByteArrayResponseWrapper.  (This may not be a Resin specific issue.)
> I will attempt to attach a patch file to this bug report containing my fix to WikiJSPFilter.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira