Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jspwiki-dev@incubator.apache.org
Date: Sat, 12 Jan 2013 22:20:12 +0000 (UTC)
From: =?utf-8?Q?Juan_Pablo_Santos_Rodr=C3=ADguez_=28JIRA=29?=
 <jira@apache.org>
To: jspwiki-dev@incubator.apache.org
Message-ID: <JIRA.12387046.1201185181376.126266.1358029212573@arcas>
In-Reply-To: <JIRA.12387046.1201185181376@arcas>
References: <JIRA.12387046.1201185181376@arcas>
Subject: [jira] [Updated] (JSPWIKI-155) Allow customisation of core classes
 via ClassUtil.getMappedObject
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/JSPWIKI-155?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan Pablo Santos Rodr=C3=ADguez updated JSPWIKI-155:
------------------------------------------------

    Fix Version/s:     (was: 3.1)
                   2.10
   =20
> Allow customisation of core classes via ClassUtil.getMappedObject
> -----------------------------------------------------------------
>
>                 Key: JSPWIKI-155
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-155
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.6.0
>            Reporter: Simon Kitching
>            Priority: Minor
>             Fix For: 2.10
>
>
> The WikiEngine class uses the ClassUtils.getMappedObject method to locate=
 its critical helper objects, rather than just call "new".
> The intentention of this existing code is for people to be able to overri=
de the core implementations with custom ones - with the warning that these =
core objects do not have stable public apis, and may change in any release.=
 Unfortunately because (a) the returned object is cast to a concrete type, =
and (b) many of these concrete types are declared "final" this facility is =
actually almost useless.
> It would be nice for the "final" to be removed from these classes, and fr=
om their member methods so that getMappedObject becomes useful. Alternately=
, interfaces could be created for the concrete classes that WikiEngine curr=
ently uses, and all code modified to use the interface instead; the existin=
g implementations could then remain final. That approach is much more intru=
sive though.
> Note that in discussions on the email lists it has been suggested that th=
e "final" qualifier on these classes helps make jspwiki more secure. Person=
ally I'm not at all convinced that is true though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira