incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Pablo Santos Rodríguez (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JSPWIKI-651) Convert JSPWiki to a Maven project
Date Mon, 17 Dec 2012 21:44:45 GMT

    [ https://issues.apache.org/jira/browse/JSPWIKI-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534331#comment-13534331
] 

Juan Pablo Santos Rodríguez commented on JSPWIKI-651:
-----------------------------------------------------

Hi Glen,

a lot of topics in last comments! My 0.02c:

- IT's issue: I've misread, when you were talking about ITs I was thinking of the Selenium
ones, duh

- code modularization: my main concern on jumping to a Maven structure right now is that build.xml
builds up a lot of generated files and sets up a lot of things, so it doesn't seem an easy
task (the initial hiccups you mention). An equivalent pom.xml to the current build.xml is
going to be real big (aside from the "usual", sonar, rat-report, precompiled-jsp-war, signing,
hsql init & shutdown, generation of jspwiki.properties,..)

- submodules: sonar's design page should give us some hints on what modules could emerge.
I'm eager to jump into submodules as soon as possible becuase in my experience, having smaller
submodules means having a ~30 lines pom + dependencies per module, which is way easier to
manage than a big, customized, pom. Attaching to the Maven project layout should also help
in minimizing the pom (i.e.: the clean ant target). If we end up with a ~1700 lines pom.xml
then we're substituting one build system with another, but we're not making it more simple.

Said that, I think you state a very good point, having a maven directory layout and a minimal
pom (i.e.: default goals + container support) should ease the hop in. I'll definitely take
a look at the CXF and Roller poms. 

@All: more opinions on this?
                
> Convert JSPWiki to a Maven project
> ----------------------------------
>
>                 Key: JSPWIKI-651
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-651
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Daniel Johansson
>            Priority: Trivial
>              Labels: ant, build, ivy, maven
>         Attachments: pom.xml
>
>
> Hello there, I was hoping to maybe one day contribute to the JSPWiki project and after
having checked out the trunk code and played around somewhat I was thinking it would be very
nice if this project used Maven.
> I'm sure most of you are familiar with Maven in one way or another, you might even have
a really good reason for not doing this to JSPWiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message