incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Jalkanen <janne.jalka...@ecyrd.com>
Subject Re: Source headers and RAT report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Date Tue, 09 Oct 2012 19:02:43 GMT

Considering that even 1.8 is over two years old (and 1.7 is from 2006), I think it's a safe
upgrade :)

/Janne

On 9 Oct 2012, at 00:10, Juan Pablo Santos Rodríguez wrote:

> Hi,
> 
> just committed the change. The rat-report task creates the report at
> $trunk/doc/rat/rat.txt
> 
> I'm still playing with it in order to get all the required changes in one
> go, but feel free to experiment and commit in the meantime. Also, the clean
> target takes care of this new dir.
> 
> This task requires at least Apache Ant 1.7.1, though. I haven't updated the
> requirements to use at least this version of Ant because this report isn't
> strictly part of the main build, but I'm not totally convinced we should
> leave it as is now.. WDYT?
> 
> 
> br,
> juan pablo
> 
> 
> On Mon, Oct 8, 2012 at 8:27 AM, Florian Holeczek <florian@holeczek.de>wrote:
> 
>> Hi all,
>> 
>> a review during the release vote on general@i.a.o brought up some
>> problems with missing headers, please see below.
>> Maybe it makes sense to integrate a RAT run into the build script, if
>> feasible.
>> 
>> Regards
>> Florian
>> 
>> 
>> -------- Original-Nachricht --------
>> Betreff: Re: [VOTE] JSPWiki version 2.9.0-incubating
>> Datum: Sun, 7 Oct 2012 14:53:47 -0700
>> Von: Craig L Russell <craig.russell@oracle.com>
>> Antwort an: general@incubator.apache.org
>> An: general@incubator.apache.org
>> 
>> Hi Christian,
>> 
>> Thanks for the review of the release.
>> 
>> On Oct 7, 2012, at 12:30 PM, Christian Grobmeier wrote:
>> 
>>> Hello,
>>> 
>>> i'm sorry to -1 your release :-(
>>> 
>>> Please see:
>>> http://www.apache.org/legal/src-headers.html#headers
>> 
>> This is a very important document to read and understand. The jspwiki
>> headers are non-standard and should be rewritten to conform. In
>> particular, there should be no extraneous verbiage before the
>> "Licensed to..." text. No copyright, no other information.
>>> 
>>> I have found a lot of code like in the the src package /src/webdocs/
>>> Captcha.jsp
>>> which are missing header licenses. I saw it is in the .java files, but
>>> they should be basically in every file we release (including jsp)
>> 
>> I agree, .jsp files need the Apache license header just as .java files
>> do.
>>> 
>>> Also export.sh misses headers.
>>> 
>>> In the headers of the .java files is: JSPWiki - a JSP-based WikiWiki
>>> clone.
>>> Not sure if this is a blocker, but you should use the full name
>>> "Apache JSPWiki" instead of only "JSPWiki". Personally I would get rid
>>> of this line actually, but i think it is up to you.
>> 
>> Getting rid of the line is probably the easiest way to conform.
>>> 
>>> Example:
>>> 
>> https://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3/src/org/apache/catalina/util/HexUtils.java
>>> 
>>> I have not tested signatures yet.
>>> 
>>> In other projects sometimes the website is being voted on together
>>> with the releases. Is it not the case with JSPWiki?
>> 
>> I don't know that I've ever voted on a web site release. Other
>> projects just update the web site as needed, with no vote.
>>> 
>>> On another note, I agree with Ross. Your mentors should have told you
>>> that and they should have voted already.
>> 
>> This first release has been a long time coming, and I was distracted
>> the last couple of weeks.
>> 
>> I agree that the mentors should review the release and advise of
>> remedial action.
>> 
>> I'd like to see a rat report on the release. I believe that analysis
>> of the rat report will reinforce the comments that Christian and I made.
>> 
>> Regards,
>> 
>> Craig
>> 
>> 
>>> Not sure if how the overall
>>> situation on your daily project life is. If you feel that you would
>>> need more mentor support, please write a separate e-mail to this list.
>>> I have only looked at this e-mail as it was open for a couple of days
>>> without much responses.
>>> 
>>> Best regards,
>>> Christian
>>> 
>>> On Thu, Sep 27, 2012 at 8:11 PM, Juan Pablo Santos Rodríguez
>>> <juanpablo@apache.org> wrote:
>>>> Hi,
>>>> 
>>>> This is a call for a vote on releasing the following candidate as
>>>> Apache
>>>> JSPWiki version 2.9.0-incubating.
>>>> This will be our first release. A vote was held on the developer
>>>> mailing
>>>> list (http://s.apache.org/dzM) and
>>>> passed with 10 +1s (* denoting PPMC):
>>>> 
>>>> Janne Jalkannen*
>>>> Florian Holeczek*
>>>> Harry Metske*
>>>> Andrew Jaquith*
>>>> Dirk Frederickx*
>>>> Juan Pablo Santos Rodríguez*
>>>> Fabian Haupt
>>>> Michael Gerzabek
>>>> Christophe Dupriez
>>>> Roberto Venturi
>>>> 
>>>> We need at least 3 IPMC votes.
>>>> 
>>>> This release fixes the following issues:
>>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12319521
>>>> 
>>>> Source and binary files:
>>>> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>>>> 
>>>> The tag to be voted upon:
>>>> 
>> https://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3
>>>> 
>>>> JSPWiki's KEYS file containing PGP keys we use to sign the release:
>>>> http://www.apache.org/dist/incubator/jspwiki/KEYS
>>>> 
>>>> 
>>>> Please download, test, and vote by 72 hours from now.
>>>> 
>>>> [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
>>>> 
>>>> 
>>>> Thanks,
>>>> juan pablo
>>> 
>>> 
>>> 
>>> --
>>> http://www.grobmeier.de
>>> https://www.timeandbill.de
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>> 
>> 
>> Craig L Russell
>> Architect, Oracle
>> http://db.apache.org/jdo
>> 408 276-5638 mailto:Craig.Russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>> 
>> 
>> 
>> 


Mime
View raw message