incubator-jspwiki-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig L Russell <craig.russ...@oracle.com>
Subject Re: Source headers and RAT report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Date Wed, 10 Oct 2012 00:14:31 GMT
Hi Juan Pablo,

Perhaps it's worth doing an svn diff|less before committing, just to  
review all of the changes about to be made. In the cases where there  
was an inadvertent change, this would have allowed you to revert the  
changes to those specific files while maintaining the efficiency of  
the mass update.

Craig

On Oct 9, 2012, at 12:58 PM, Juan Pablo Santos Rodríguez wrote:

> Hi,
>
> thanks for noticing, the bulk change was made through a sed script,  
> which
> touched the file but didn't do anything to it. After checking that the
> build wasn't broken and that the 200 first files contained a two- 
> line diff,
> I assumed that the rest was ok.
>
> btw, just noticed: TortoiseSVN showed a 2 line difference for every  
> file,
> but viewvc shows that the whole file is changed. I was about to make
> another bulk commit in a while to introduce the header in all the  
> JSPs, so
> I'm afraid I'm going to be a little disruptive again in about 1-2  
> hours..
>
>
> br,
> juan pablo
>
>
> On Tue, Oct 9, 2012 at 8:21 PM, Harry Metske  
> <harry.metske@gmail.com> wrote:
>
>> I noticed that one too this morning, let me fix that in a few  
>> moments.
>>
>> regards,
>> Harry
>>
>> 2012/10/9 Craig L Russell <craig.russell@oracle.com>
>>
>>> Hi Juan Pablo,
>>>
>>> I just noticed on anomaly. http://svn.apache.org/viewvc/**
>>> incubator/jspwiki/trunk/tests/**org/apache/wiki/plugin/**
>>> IfPluginTest.java?view=markup<
>> http://svn.apache.org/viewvc/incubator/jspwiki/trunk/tests/org/apache/wiki/plugin/IfPluginTest.java?view=markup
>>>
>>>
>>> The script changed this file but it (still) has no license header.
>>>
>>> Craig
>>>
>>>
>>> On Oct 8, 2012, at 3:36 PM, Juan Pablo Santos Rodríguez wrote:
>>>
>>> quick update: .java files now conform strictly to AL header (as  
>>> noted at
>>>> http://s.apache.org/EDd). Apologies on the mass commit, this was  
>>>> done
>>>> with
>>>> a sed script to make it in one go. JSPs and some javascript files  
>>>> still
>>>> need their proper header.
>>>>
>>>>
>>>> br,
>>>> juan pablo
>>>>
>>>>
>>>>
>>> Craig L Russell
>>> Architect, Oracle
>>> http://db.apache.org/jdo
>>> 408 276-5638 mailto:Craig.Russell@oracle.**com <Craig.Russell@oracle.com
>>>
>>> P.S. A good JDO? O, Gasp!
>>>
>>>
>>

Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!


Mime
View raw message