Return-Path: X-Original-To: apmail-incubator-jspwiki-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-jspwiki-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 330C5DE4F for ; Wed, 27 Jun 2012 07:19:08 +0000 (UTC) Received: (qmail 3474 invoked by uid 500); 27 Jun 2012 07:19:08 -0000 Delivered-To: apmail-incubator-jspwiki-dev-archive@incubator.apache.org Received: (qmail 3398 invoked by uid 500); 27 Jun 2012 07:19:07 -0000 Mailing-List: contact jspwiki-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jspwiki-dev@incubator.apache.org Delivered-To: mailing list jspwiki-dev@incubator.apache.org Received: (qmail 3376 invoked by uid 99); 27 Jun 2012 07:19:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jun 2012 07:19:06 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of janne.jalkanen@ecyrd.com designates 87.108.86.67 as permitted sender) Received: from [87.108.86.67] (HELO mail.ecyrd.com) (87.108.86.67) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jun 2012 07:19:00 +0000 Received: from [192.168.0.59] (unknown [83.145.245.61]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.ecyrd.com (Postfix) with ESMTPSA id 472D4135A0F2 for ; Wed, 27 Jun 2012 10:18:39 +0300 (EEST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Apple Message framework v1084) Subject: Re: code coverage and sonar integration From: Janne Jalkanen In-Reply-To: Date: Wed, 27 Jun 2012 10:18:38 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <0FE13B61-8A7C-425A-93A6-75124DF7DC7A@ecyrd.com> References: To: jspwiki-dev@incubator.apache.org X-Mailer: Apple Mail (2.1084) X-Virus-Checked: Checked by ClamAV on apache.org Nope. But what you can do is to make an ant task which downloads Cobertura and = the relevant JARs when you run "ant coverage-tests" or whatever. /Janne On 27 Jun 2012, at 01:11, Juan Pablo Santos Rodr=EDguez wrote: > Hi again, >=20 > I was curious and have added the needed jars and the related ant task = to > see how JSPWiki is performing in terms of test coverage. I was about = to > commit the changes, but I'm not very sure if we can commit the = Cobertura > jar, as it is not clear to me if their license is AL-compatible or not = (by > the way, if anybody is curious, I've uploaded the reports to [1]). >=20 > Cobertura ant tasks are AL-licensed [2], but cobertura.jar contains = both > ant-tasks and Cobertura itself, which is GPL. Is it OK to commit this = jar > in tests/lib? Regarding asm-3.0.jar and asm-tree-3.0.jar, they seem OK = [3]. >=20 > Also, following up with the coverage reports, I've also made the = appropiate > task to let Sonar gather some statistics from JSPWiki. The point is, = Sonar > is LGPL'ed, which means we can't add the Sonar ant tasks to the = project, > so, does it make sense to commit these build.xml changes? As I have = them > now, they assume that the Sonar ant tasks are placed inside = $ANT_HOME/lib >=20 >=20 > regards, > juan pablo >=20 >=20 > [1]: http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3 > [2]: http://cobertura.sourceforge.net/license.html > [3]: http://asm.ow2.org/license.html